Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 746043002: Small changes to get things building and running on Linux/ARM. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Small changes to get things building and running on Linux/ARM. ninja -C out/Debug works, and I tested out/Debug/dm --nogpu (no X yet). The only problems encountered were: - Like CrOS, I also needed to use the default float ABI (presumably hard). - The strings in GrBinHashKeyTest weren't necessarily 4-byte aligned. BUG=skia: Committed: https://skia.googlesource.com/skia/+/19996eda62181982d35c36e29515c1fe9c9fb2a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrBinHashKeyTest.cpp View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746043002/1
6 years, 1 month ago (2014-11-21 03:58:44 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-21 03:58:45 UTC) #3
mtklein_C
6 years, 1 month ago (2014-11-21 03:59:08 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-21 08:00:11 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-11-21 14:00:17 UTC) #8
bsalomon
On 2014/11/21 14:00:17, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-21 14:42:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746043002/1
6 years, 1 month ago (2014-11-21 14:48:37 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 14:48:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19996eda62181982d35c36e29515c1fe9c9fb2a3

Powered by Google App Engine
This is Rietveld 408576698