Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 746003002: Enable webrtc and most of blink and content in the Mac GN build. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
jamesr, brettw
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable webrtc and most of blink and content in the Mac GN build. There are still a few linker errors from missing files. I'll try to get those fixed in a follow-on build, but this adds several thousand edges as-is. R=brettw@chromium.org BUG=431177 Committed: https://crrev.com/380390fc2b8257979d5a2ce830947a6db0aab15d Cr-Commit-Position: refs/heads/master@{#305179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -70 lines) Patch
M BUILD.gn View 2 chunks +1 line, -19 lines 0 comments Download
M cc/blink/BUILD.gn View 1 chunk +20 lines, -17 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +29 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/BUILD.gn View 1 chunk +35 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
6 years, 1 month ago (2014-11-21 01:45:19 UTC) #1
jamesr
lgtm
6 years, 1 month ago (2014-11-21 01:47:01 UTC) #3
brettw
lgtm
6 years, 1 month ago (2014-11-21 05:26:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746003002/1
6 years, 1 month ago (2014-11-21 05:26:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 06:09:00 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 06:10:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/380390fc2b8257979d5a2ce830947a6db0aab15d
Cr-Commit-Position: refs/heads/master@{#305179}

Powered by Google App Engine
This is Rietveld 408576698