Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 745963005: Add support for downloading clang (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Add support for downloading clang Still requires changes to gyp files to select the built-in clang as compiler and make clang the default on the platforms we want it. BUG= R=dcarney@chromium.org,machenbach@chromium.org LOG=n

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +9 lines, -0 lines 5 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-11-26 14:17:08 UTC) #1
dcarney
lgtm
6 years ago (2014-11-26 14:18:52 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/745963005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/745963005/diff/1/DEPS#newcode22 DEPS:22: Var("git_url") + "/chromium/src/tools/clang.git@327e26ee7f6ae6f86fb335113b46cb86ed3cb0dc", Be aware of make dependencies... ...
6 years ago (2014-11-26 15:08:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745963005/1
6 years ago (2014-11-27 10:02:14 UTC) #5
jochen (gone - plz use gerrit)
https://codereview.chromium.org/745963005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/745963005/diff/1/DEPS#newcode22 DEPS:22: Var("git_url") + "/chromium/src/tools/clang.git@327e26ee7f6ae6f86fb335113b46cb86ed3cb0dc", On 2014/11/26 15:08:34, Michael Achenbach wrote: ...
6 years ago (2014-11-27 10:02:39 UTC) #6
Michael Achenbach
https://codereview.chromium.org/745963005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/745963005/diff/1/DEPS#newcode22 DEPS:22: Var("git_url") + "/chromium/src/tools/clang.git@327e26ee7f6ae6f86fb335113b46cb86ed3cb0dc", On 2014/11/27 10:02:39, jochen (slow) wrote: ...
6 years ago (2014-11-27 10:13:05 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-27 10:29:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698