Issue 745913002: Start moving files from core/inspector into v8_inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 745913002: Start moving files from core/inspector into v8_inspector (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan, yurys

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Start moving files from core/inspector into v8_inspector This was just a test. I'm about to write a script to automate this process. Mostly I just need to fix tools/git/move_source_file.py to work for blink. TBR=abarth@chromium.org BUG=435243 Committed: https://chromium.googlesource.com/external/mojo/+/f56f7d211c8ff9d1b8a97f7a0f483b017b056029

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -620 lines)			Patch
D	sky/engine/bindings/core/v8/PageScriptDebugServer.h	View	1 chunk	+0 lines, -106 lines	0 comments	Download
D	sky/engine/bindings/core/v8/PageScriptDebugServer.cpp	View	1 chunk	+0 lines, -315 lines	0 comments	Download
M	sky/engine/bindings/core/v8/v8.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/core/inspector/PageDebuggerAgent.h	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	sky/engine/core/inspector/PageDebuggerAgent.cpp	View	1 chunk	+0 lines, -111 lines	0 comments	Download
M	sky/engine/v8_inspector/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	sky/engine/v8_inspector/PageDebuggerAgent.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/engine/v8_inspector/PageDebuggerAgent.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/engine/v8_inspector/PageScriptDebugServer.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sky/engine/v8_inspector/PageScriptDebugServer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/v8_inspector/inspector_backend_mojo.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eseidel

6 years, 1 month ago (2014-11-20 23:07:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f56f7d211c8ff9d1b8a97f7a0f483b017b056029.

Expand Messages | Collapse Messages