sky/examples/style/block-layout.sky - Issue 745863002: Specs: update the layout and paint schemes to match discussions better

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/style/block-layout.sky

Issue 745863002: Specs: update the layout and paint schemes to match discussions better (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/examples/style/block-layout.sky

diff --git a/sky/examples/style/block-layout.sky b/sky/examples/style/block-layout.sky

index b0e67ba0ddf9fb84efa3d1f2dd6e654ecbe54802..a707af0e54a430c0a11509ce52ac31da6c650ae8 100644

--- a/sky/examples/style/block-layout.sky

+++ b/sky/examples/style/block-layout.sky

@@ -21,7 +21,7 @@ SKY MODULE

let y = 0;

while (!loop.done) {

let child = loop.value;

- if (child.needsLayout) {

+ if (child.needsLayout || child.descendantNeedsLayout) {

let dims = child.layoutManager.layout(width, null);

this.setChildSize(child, dims.width, dims.height);

}

« no previous file with comments | « sky/examples/README.md ('k') | sky/examples/style/hex-layout.sky » ('j') | no next file with comments »