Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 74583003: Fix data view accessors to throw execptions on offsets bigger than size_t. (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix data view accessors to throw execptions on offsets bigger than size_t. R=jkummerow@chromium.org BUG=v8:3013 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=17840

Patch Set 1 #

Patch Set 2 : Fix after a bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M src/runtime.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/v8conversions.h View 1 1 chunk +25 lines, -10 lines 0 comments Download
M test/mjsunit/harmony/dataview-accessors.js View 11 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
PTAL.
7 years, 1 month ago (2013-11-18 14:42:18 UTC) #1
Jakob Kummerow
lgtm
7 years, 1 month ago (2013-11-18 14:52:08 UTC) #2
Dmitry Lomov (no reviews)
Committed patchset #1 manually as r17838 (presubmit successful).
7 years, 1 month ago (2013-11-18 14:58:24 UTC) #3
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-18 15:16:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698