Issue 745823002: GYP: fix compile flake for second-hand use of generated headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 745823002: GYP: fix compile flake for second-hand use of generated headers. (Closed)

Created:
6 years, 1 month ago by Nick Bray (chromium)

Modified:
5 years, 6 months ago

Reviewers:
Torne

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

GYP: fix compile flake for second-hand use of generated headers. NOT FOR COMMIT - Chrome testing for Mojo-side change. BUG=https://code.google.com/p/chromium/issues/detail?id=435144

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : No export #

Patch Set 4 : Testing hack #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	mojo/public/mojo_public.gyp	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi	View	1 2 3	4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Torne

suppress_wildcard should work sensibly for android_aosp now. Apologies for the breakage.

6 years ago (2014-11-27 17:58:04 UTC) #2

Is this still needed?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages