Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/pylib/base/test_run_factory.py

Issue 745793002: Add AMP support to test runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/base/test_run.py ('k') | build/android/pylib/constants.py » ('j') | build/android/pylib/gtest/gtest_test_instance.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base/test_run_factory.py
diff --git a/build/android/pylib/base/test_run_factory.py b/build/android/pylib/base/test_run_factory.py
index 6ccfb37ec95afb146d4fb57072b551440f617da4..80856c2afd8b688bfce08c8945770a664f5556c0 100644
--- a/build/android/pylib/base/test_run_factory.py
+++ b/build/android/pylib/base/test_run_factory.py
@@ -2,9 +2,17 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-def CreateTestRun(_args, _env, _test_instance, error_func):
+from pylib.remote.device import remote_device_gtest_run
+from pylib.remote.device import remote_device_uirobot_run
+def CreateTestRun(args, env, test_instance, error_func):
+ if args.environment == 'remote_device':
+ if test_instance.TestType() == 'gtest':
+ return remote_device_gtest_run.RemoteDeviceGtestRun(env, test_instance)
+ if test_instance.TestType() == 'uirobot':
+ return remote_device_uirobot_run.RemoteDeviceUirobotRun(
+ env,test_instance)
jbudorick 2014/12/05 01:01:46 nit: space after the comma I'm surprised pylint i
rnephew (Reviews Here) 2014/12/05 15:45:40 Done.
# TODO(jbudorick) Add local gtest test runs
# TODO(jbudorick) Add local instrumentation test runs.
- error_func('No test runs are currently supported.')
-
+ error_func('Unable to create %s test run in %s environment' % (
+ test_instance.TestType(), args.environment ))
jbudorick 2014/12/05 01:01:46 nit: no space after environment
rnephew (Reviews Here) 2014/12/05 15:45:40 Done.
« no previous file with comments | « build/android/pylib/base/test_run.py ('k') | build/android/pylib/constants.py » ('j') | build/android/pylib/gtest/gtest_test_instance.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698