build/android/pylib/base/test_run_factory.py - Issue 745793002: Add AMP support to test runner.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/base/test_run_factory.py

Issue 745793002: Add AMP support to test runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« build/android/pylib/base/environment_factory.py ('K') | « build/android/pylib/base/test_run.py ('k') | build/android/pylib/constants.py » ('j') | build/android/pylib/remote/device/remote_device_environment.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 def CreateTestRun(_args, _env, _test_instance, error_func):	5 from pylib.remote.device import remote_device_gtest_run

	6 from pylib.remote.device import remote_device_uirobot_run

6	7

	8 def CreateTestRun(options, env, test_instance, error_func):
	jbudorick 2014/12/04 21:51:33 rename options -> args rename options -> args rnephew (Reviews Here) 2014/12/04 23:16:50 Done. Show quoted text On 2014/12/04 21:51:33, jbudorick wrote: > rename options -> args Done.
	9 if (options.environment == 'remote_device'):
	jbudorick 2014/12/04 21:51:33 no parentheses around the if condition no parentheses around the if condition rnephew (Reviews Here) 2014/12/04 23:16:50 Done. Show quoted text On 2014/12/04 21:51:33, jbudorick wrote: > no parentheses around the if condition Done.
	10 if (test_instance.TestType() == 'gtest'):
	jbudorick 2014/12/04 21:51:33 same same rnephew (Reviews Here) 2014/12/04 23:16:50 Done. Show quoted text On 2014/12/04 21:51:33, jbudorick wrote: > same Done.
	11 return remote_device_gtest_run.RemoteDeviceGtestRun(env, test_instance)

	12 if (test_instance.TestType() == 'uirobot'):
	jbudorick 2014/12/04 21:51:33 same same rnephew (Reviews Here) 2014/12/04 23:16:50 Done. Show quoted text On 2014/12/04 21:51:33, jbudorick wrote: > same Done.
	13 return remote_device_uirobot_run.RemoteDeviceUirobotRun(

	14 env,test_instance)

7 # TODO(jbudorick) Add local gtest test runs	15 # TODO(jbudorick) Add local gtest test runs

8 # TODO(jbudorick) Add local instrumentation test runs.	16 # TODO(jbudorick) Add local instrumentation test runs.

9 error_func('No test runs are currently supported.')	17 error_func('No test runs are currently supported.')
	jbudorick 2014/12/04 21:51:33 rephrase rephrase rnephew (Reviews Here) 2014/12/04 23:16:50 Done. Show quoted text On 2014/12/04 21:51:33, jbudorick wrote: > rephrase Done.
10	18

OLD	NEW