build/android/pylib/base/environment_factory.py - Issue 745793002: Add AMP support to test runner.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/base/environment_factory.py

Issue 745793002: Add AMP support to test runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 from pylib.remote.device import remote_device_environment

5	6

6 def CreateEnvironment(_args, error_func):	7 def CreateEnvironment(_args, error_func):
	jbudorick 2014/12/04 21:51:33 _args -> args, you're using it now _args -> args, you're using it now rnephew (Reviews Here) 2014/12/04 23:16:50 Done. Show quoted text On 2014/12/04 21:51:33, jbudorick wrote: > _args -> args, you're using it now Done.
7	8

8 # TODO(jbudorick) Add local device environment.	9 # TODO(jbudorick) Add local device environment.

9 # TODO(jbudorick) Add local machine environment.	10 # TODO(jbudorick) Add local machine environment.

10 error_func('No environments currently supported.')

11	11

	12 if _args.environment == 'remote_device':

	13 return remote_device_environment.RemoteDeviceEnvironment(_args,

	14 error_func)

	15 error_func('Unable to create %s environment.' % _args.environment)

OLD	NEW