Makes views be initially hidden

mojo/services/view_manager/view_manager_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/public/interfaces/application/service_provider.mojom.h"
@@ skipping 238 matching lines @@
 // Provides common setup for animation tests. Creates the following views:
 // 0,1 (the root, provided by view manager)
 //   1,1 the second connection is embedded here (view owned by wm_connection()).
 //     2,1 bounds=1,2 11x22
 //       2,2 bounds=2,3 6x7
 //         2,3 bounds=3,4 6x7
 // CloneAndAnimate() is invoked for 2,2.
 void SetUpAnimate1(ViewManagerServiceTest* test, ViewId* embed_view_id) {
   *embed_view_id = ViewId(test->wm_connection()->id(), 1);
   EXPECT_EQ(ERROR_CODE_NONE, test->wm_connection()->CreateView(*embed_view_id));
+  EXPECT_TRUE(test->wm_connection()->SetViewVisibility(*embed_view_id, true));
   EXPECT_TRUE(test->wm_connection()->AddView(*(test->wm_connection()->root()),
                                              *embed_view_id));
   EXPECT_TRUE(test->wm_connection()->Embed(
       std::string(), *embed_view_id, InterfaceRequest<ServiceProvider>()));
   ViewManagerServiceImpl* connection1 =
       test->connection_manager()->GetConnectionWithRoot(*embed_view_id);
   ASSERT_TRUE(connection1 != nullptr);
   ASSERT_NE(connection1, test->wm_connection());
 
   const ViewId child1(connection1->id(), 1);
   EXPECT_EQ(ERROR_CODE_NONE, connection1->CreateView(child1));
   const ViewId child2(connection1->id(), 2);
   EXPECT_EQ(ERROR_CODE_NONE, connection1->CreateView(child2));
   const ViewId child3(connection1->id(), 3);
   EXPECT_EQ(ERROR_CODE_NONE, connection1->CreateView(child3));
 
   ServerView* v1 = connection1->GetView(child1);
+  v1->SetVisible(true);
   v1->SetBounds(gfx::Rect(1, 2, 11, 22));
   ServerView* v2 = connection1->GetView(child2);
+  v2->SetVisible(true);
   v2->SetBounds(gfx::Rect(2, 3, 6, 7));
   ServerView* v3 = connection1->GetView(child3);
+  v3->SetVisible(true);
   v3->SetBounds(gfx::Rect(3, 4, 6, 7));
 
   EXPECT_TRUE(connection1->AddView(*embed_view_id, child1));
   EXPECT_TRUE(connection1->AddView(child1, child2));
   EXPECT_TRUE(connection1->AddView(child2, child3));
 
   TestViewManagerClient* connection1_client = test->last_view_manager_client();
   connection1_client->tracker()->changes()->clear();
   test->wm_client()->tracker()->changes()->clear();
   EXPECT_TRUE(test->connection_manager()->CloneAndAnimate(child2));
@@ skipping 92 matching lines @@
   EXPECT_TRUE(cloned_view->GetChildren()[0]->id() == ClonedViewId());
   EXPECT_EQ(2u, cloned_view->parent()->GetChildren().size());
   EXPECT_TRUE(cloned_view->parent()->GetChildren()[1] == cloned_view);
 }
 
 // Clone and animate on a tree with more depth. Basically that of
 // SetUpAnimate1() but cloning 2,1.
 TEST_F(ViewManagerServiceTest, CloneAndAnimateLargerDepth) {
   const ViewId embed_view_id(wm_connection()->id(), 1);
   EXPECT_EQ(ERROR_CODE_NONE, wm_connection()->CreateView(embed_view_id));
+  EXPECT_TRUE(wm_connection()->SetViewVisibility(embed_view_id, true));
   EXPECT_TRUE(
       wm_connection()->AddView(*(wm_connection()->root()), embed_view_id));
   EXPECT_TRUE(wm_connection()->Embed(std::string(), embed_view_id,
                                      InterfaceRequest<ServiceProvider>()));
   ViewManagerServiceImpl* connection1 =
       connection_manager()->GetConnectionWithRoot(embed_view_id);
   ASSERT_TRUE(connection1 != nullptr);
   ASSERT_NE(connection1, wm_connection());
 
   const ViewId child1(connection1->id(), 1);
   EXPECT_EQ(ERROR_CODE_NONE, connection1->CreateView(child1));
   const ViewId child2(connection1->id(), 2);
   EXPECT_EQ(ERROR_CODE_NONE, connection1->CreateView(child2));
   const ViewId child3(connection1->id(), 3);
   EXPECT_EQ(ERROR_CODE_NONE, connection1->CreateView(child3));
 
   ServerView* v1 = connection1->GetView(child1);
+  v1->SetVisible(true);
+  connection1->GetView(child2)->SetVisible(true);
+  connection1->GetView(child3)->SetVisible(true);
 
   EXPECT_TRUE(connection1->AddView(embed_view_id, child1));
   EXPECT_TRUE(connection1->AddView(child1, child2));
   EXPECT_TRUE(connection1->AddView(child2, child3));
 
   TestViewManagerClient* connection1_client = last_view_manager_client();
   connection1_client->tracker()->changes()->clear();
   wm_client()->tracker()->changes()->clear();
   EXPECT_TRUE(connection_manager()->CloneAndAnimate(child1));
   EXPECT_TRUE(connection1_client->tracker()->changes()->empty());
   EXPECT_TRUE(wm_client()->tracker()->changes()->empty());
 
   // We cloned v1. The cloned view ends up as a sibling of it.
   const ServerView* cloned_view = GetFirstCloned(v1->parent());
   ASSERT_TRUE(cloned_view);
   // |cloned_view| should have a child and its child should have a child.
   ASSERT_EQ(1u, cloned_view->GetChildren().size());
   const ServerView* cloned_view_child = cloned_view->GetChildren()[0];
   EXPECT_EQ(1u, cloned_view_child->GetChildren().size());
   EXPECT_TRUE(cloned_view_child->id() == ClonedViewId());
 }
 
 }  // namespace service
 }  // namespace mojo