Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 745743002: Makes views be initially hidden (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Makes views be initially hidden This better matches what other toolkits do and lets the client configure the view before we attempt to show something for it. BUG=434429 TEST=covered by test R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0fb0af3d793ece4028f0babad908aeed20822113

Patch Set 1 #

Patch Set 2 : fix initial visibility of view and debug stuff #

Patch Set 3 : moar #

Total comments: 2

Patch Set 4 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -31 lines) Patch
M examples/media_viewer/media_viewer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M examples/nesting_app/nesting_app.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M examples/window_manager/window_manager.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M examples/wm_flow/app/app.cc View 1 chunk +1 line, -0 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M examples/wm_flow/wm/wm.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 12 chunks +16 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.cc View 1 2 chunks +25 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_apptest.cc View 6 chunks +28 lines, -14 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_unittest.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 6 chunks +21 lines, -6 lines 0 comments Download
M mojo/services/window_manager/main.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/views/native_widget_view_manager.h View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/tester/tester.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 1 month ago (2014-11-20 20:15:01 UTC) #1
Elliot Glaysher
https://codereview.chromium.org/745743002/diff/40001/examples/nesting_app/nesting_app.cc File examples/nesting_app/nesting_app.cc (right): https://codereview.chromium.org/745743002/diff/40001/examples/nesting_app/nesting_app.cc#newcode72 examples/nesting_app/nesting_app.cc:72: nested_->SetVisible(true); If you're going to add SetVisible() calls to ...
6 years, 1 month ago (2014-11-20 20:34:37 UTC) #2
sky
https://codereview.chromium.org/745743002/diff/40001/examples/nesting_app/nesting_app.cc File examples/nesting_app/nesting_app.cc (right): https://codereview.chromium.org/745743002/diff/40001/examples/nesting_app/nesting_app.cc#newcode72 examples/nesting_app/nesting_app.cc:72: nested_->SetVisible(true); On 2014/11/20 20:34:37, Elliot Glaysher wrote: > If ...
6 years, 1 month ago (2014-11-20 20:51:30 UTC) #3
Elliot Glaysher
lgtm
6 years, 1 month ago (2014-11-20 20:55:05 UTC) #4
sky
6 years, 1 month ago (2014-11-20 21:04:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
0fb0af3d793ece4028f0babad908aeed20822113.

Powered by Google App Engine
This is Rietveld 408576698