Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py

Issue 745733002: Add support in Telemetry for specifying exact Android APK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final nit Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py
index d03123e20c8151711762fd94673571f1be41db05..8f8dc1f295619b778bf246c36854db9079832101 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py
@@ -175,6 +175,13 @@ class LinuxFindTest(FindTestBase):
self._finder_options.browser_executable = '/foo/chrome'
self.assertIn('exact', self.DoFindAllTypes())
+ def testFindWithProvidedApk(self):
+ if not self.CanFindAvailableBrowsers():
+ return
+
+ self._finder_options.browser_executable = '/foo/chrome.apk'
+ self.assertNotIn('exact', self.DoFindAllTypes())
+
def testFindUsingDefaults(self):
if not self.CanFindAvailableBrowsers():
return
@@ -237,3 +244,15 @@ class WinFindTest(FindTestBase):
'debug', 'release',
'content-shell-debug', 'content-shell-release',
'system', 'canary']))
+
+ def testFindAllWithExactApk(self):
+ if not self.CanFindAvailableBrowsers():
+ return
+
+ self._finder_options.browser_executable = 'c:\\tmp\\chrome_shell.apk'
+ types = self.DoFindAllTypes()
+ self.assertEquals(
+ set(types),
+ set(['debug', 'release',
+ 'content-shell-debug', 'content-shell-release',
+ 'system', 'canary']))
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py ('k') | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698