Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 745673002: Fix uninitialized member in SafeBrowsingDatabaseNew (Closed)

Created:
6 years, 1 month ago by gab
Modified:
6 years, 1 month ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a1_pythonSBfix
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized member in SafeBrowsingDatabaseNew. Switch to using delegating constructors (https://chromium-cpp.appspot.com/) to streamline initialization. This was probably not an issue in practice as |change_detected_| is only read in UpdateFinished() and is always set in UpdateStarted(). BUG=Uninitialized |change_detected_| member. Committed: https://crrev.com/7cd21209b80f6fd444e866f2090705b8f2b575f9 Cr-Commit-Position: refs/heads/master@{#305103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gab
Matt, PTAL and CQ if it LGTY. Thanks, Gab
6 years, 1 month ago (2014-11-20 16:44:41 UTC) #2
mattm
lgtm
6 years, 1 month ago (2014-11-20 22:20:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745673002/1
6 years, 1 month ago (2014-11-20 22:22:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 23:06:49 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 23:07:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cd21209b80f6fd444e866f2090705b8f2b575f9
Cr-Commit-Position: refs/heads/master@{#305103}

Powered by Google App Engine
This is Rietveld 408576698