Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 745633002: [turbofan] Clean up and factor out branch generation logic. (Closed)

Created:
6 years, 1 month ago by titzer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Clean up and factor out branch generation logic. R=dcarney@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/aed26c05a50b2a1257ef8accc67143825f2e1f60

Patch Set 1 #

Patch Set 2 : Fix IA32. #

Patch Set 3 : Fix IA32 fall through. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -177 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 3 chunks +11 lines, -17 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +11 lines, -17 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/code-generator.h View 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +29 lines, -8 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 chunks +15 lines, -19 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 7 chunks +20 lines, -26 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 13 chunks +25 lines, -29 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 3 chunks +13 lines, -18 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
6 years, 1 month ago (2014-11-20 14:16:19 UTC) #1
dcarney
lgtm
6 years, 1 month ago (2014-11-20 14:19:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745633002/1
6 years, 1 month ago (2014-11-20 14:21:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745633002/40001
6 years, 1 month ago (2014-11-20 14:53:46 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 16:23:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698