Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 745613003: Revert 185598 "Fix lifespan of ScopedStyleResolver" (Closed)

Created:
6 years, 1 month ago by kochi
Modified:
6 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews
Visibility:
Public.

Description

Revert 185598 "Fix lifespan of ScopedStyleResolver" Reason: regressed on trunk, which is filed as crbug.com/434970. This needs rework and shall be committed with this layout test and more appropriate fix. > Fix lifespan of ScopedStyleResolver > > When a Shadow Tree is moved between different documents > (e.g. document <-> iframe), ScopedStyleResolver can remain > registered from its original document, which can result in > duplicate registration and possibly cause double-free etc. > > This CL fixes it by clearing a shadow tree's > ScopedStyleResolver when the ShadowRoot is removed. > > BUG=427249 > TEST=pass the new layout test > > Review URL: https://codereview.chromium.org/721103002 TBR=kochi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185673

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
kochi
6 years, 1 month ago (2014-11-20 15:49:49 UTC) #1
kochi
6 years, 1 month ago (2014-11-20 15:50:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r185673.

Powered by Google App Engine
This is Rietveld 408576698