[cros] Cleanup: remove LoginUtils

[cros] Cleanup: remove LoginUtils

Introduced UserSessionManagerTestApi:
* InjectStubUserContext() to configure predefined user credentials (StubAuthenticator)
* SetShouldLaunchBrowserInTests() to control whether browser instance should be created in tests. Some tests don't really need that and were not designed to handle it properly.

LoginUtils methods:
* IsWhitelisted() is moved to CrosSettings
* CreateAuthenticator() is moved to UserSessionManager
* PrepareProfile() and DoBrowserLaunch() were already just a thin wrappers around corresponding methods of UserSessionManager.

Tests changes:
* MockAuthenticator > StubAuthenticator
* Now tests that were using MockLoginUtils to inject their own test profile are using regular profile init code with a stub user_context.

BUG=435094
TBR=stevenjb@chromium.org

Committed: https://crrev.com/393309fdf609591e8b3225728992011b0c772cfa
Cr-Commit-Position: refs/heads/master@{#314798}

[Nikita (slow), 2014-11-26 17:49:17]

Patchset #4 (id:50001) has been deleted

[Nikita (slow), 2015-01-29 16:25:28]

nkostylev@chromium.org changed reviewers:
+ dpolukhin@chromium.org

[Nikita (slow), 2015-01-29 16:25:29]

Dmitry, please review.

Some changes like those in network_screen.cc were needed since tests are now
running more production code instead of mocks/stubs.

[Dmitry Polukhin, 2015-02-03 11:33:07]

lgtm

https://codereview.chromium.org/745613002/diff/390001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/745613002/diff/390001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:506:
WizardController* controller = WizardController::default_controller();
What do you think about moving this logic to test teardown?

[Nikita (slow), 2015-02-03 13:12:26]

https://codereview.chromium.org/745613002/diff/390001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/745613002/diff/390001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:506:
WizardController* controller = WizardController::default_controller();
On 2015/02/03 11:33:07, Dmitry Polukhin wrote:
> What do you think about moving this logic to test teardown?

Done.

[Nikita (slow), 2015-02-03 13:16:59]

nkostylev@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Nikita (slow), 2015-02-03 13:17:00]

TBR'ing stevenjb@ for owners review of
chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc

[Nikita (slow), 2015-02-03 15:27:38]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-02-03 15:31:09]

The CQ bit was unchecked by nkostylev@chromium.org

[stevenjb, 2015-02-03 17:22:45]

login_state_notification_blocker_chromeos_browsertest.cc lgtm

[Nikita (slow), 2015-02-05 10:27:01]

Patchset #26 (id:510001) has been deleted

[Nikita (slow), 2015-02-05 10:27:12]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2015-02-05 10:27:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/745613002/490001

[commit-bot: I haz the power, 2015-02-05 13:58:12]

Committed patchset #25 (id:490001)

[commit-bot: I haz the power, 2015-02-05 13:59:32]

Patchset 25 (id:??) landed as
https://crrev.com/393309fdf609591e8b3225728992011b0c772cfa
Cr-Commit-Position: refs/heads/master@{#314798}