Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 745553002: IDB: Layout test showing ro transactions wait for rw transactions (Closed)

Created:
6 years, 1 month ago by dgrogan
Modified:
6 years, 1 month ago
Reviewers:
jsbell
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Project:
blink
Visibility:
Public.

Description

IDB: Layout test showing ro transactions wait for rw transactions BUG=432259 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185759

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove hyphen #

Patch Set 3 : remove hyphen from -expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
A LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/storage/indexeddb/transaction-coordination-ro-waits-for-rw.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/storage/indexeddb/transaction-coordination-ro-waits-for-rw-expected.txt View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgrogan
Josh, could you review this? The logic change is in https://codereview.chromium.org/742033002/
6 years, 1 month ago (2014-11-20 09:25:52 UTC) #2
jsbell
lgtm https://codereview.chromium.org/745553002/diff/1/LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js File LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js (right): https://codereview.chromium.org/745553002/diff/1/LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js#newcode6 LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js:6: description("read-only transaction should see the result of a ...
6 years, 1 month ago (2014-11-20 18:39:19 UTC) #3
dgrogan
https://codereview.chromium.org/745553002/diff/1/LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js File LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js (right): https://codereview.chromium.org/745553002/diff/1/LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js#newcode6 LayoutTests/storage/indexeddb/resources/transaction-coordination-ro-waits-for-rw.js:6: description("read-only transaction should see the result of a previous ...
6 years, 1 month ago (2014-11-21 01:33:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745553002/40001
6 years, 1 month ago (2014-11-21 03:20:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 05:22:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185759

Powered by Google App Engine
This is Rietveld 408576698