Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 745543002: Revert of Rename String.prototype.contains to 'includes'. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert of Rename String.prototype.contains to 'includes'. (patchset #1 id:1 of https://codereview.chromium.org/742963002/) Reason for revert: Breaks test262-es6: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/1289 Original issue's description: > Rename String.prototype.contains to 'includes'. > > Per TC39 Nov 2014 decison. > > R=arv@chromium.org,yangguo@chromium.org > LOG=Y > > Committed: https://chromium.googlesource.com/v8/v8/+/b5379216e23ff0ec734e70361dd07057c2421c96 TBR=arv@chromium.org,yangguo@chromium.org,dslomov@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/v8/v8/+/cdc6e159bab8bee5d8b084bf0e370873d0968a38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -175 lines) Patch
M src/harmony-string.js View 2 chunks +4 lines, -4 lines 0 comments Download
M test/js-perf-test/Strings/harmony-string.js View 2 chunks +5 lines, -5 lines 0 comments Download
A test/mjsunit/harmony/string-contains.js View 1 chunk +166 lines, -0 lines 0 comments Download
D test/mjsunit/harmony/string-includes.js View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Rename String.prototype.contains to 'includes'.
6 years, 1 month ago (2014-11-20 09:03:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745543002/1
6 years, 1 month ago (2014-11-20 09:03:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 09:03:51 UTC) #3
Yang
On 2014/11/20 09:03:05, Michael Achenbach wrote: > Created Revert of Rename String.prototype.contains to 'includes'. LGTM. ...
6 years, 1 month ago (2014-11-20 09:04:12 UTC) #4
mathias
6 years, 1 month ago (2014-11-20 09:55:49 UTC) #5
Message was sent while issue was closed.
On 2014/11/20 09:04:12, Yang wrote:
> On 2014/11/20 09:03:05, Michael Achenbach wrote:
> > Created Revert of Rename String.prototype.contains to 'includes'.
> 
> LGTM. test262-es6.status needs to be updated before relanding.

test262 patch: https://github.com/tc39/test262/pull/119

Powered by Google App Engine
This is Rietveld 408576698