Issue 745493002: Profile FreeList (chromium side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 745493002: Profile FreeList (chromium side)

Created:
6 years, 1 month ago by keishi

Modified:
5 years, 11 months ago

Reviewers:

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Profile FreeList (chromium side) This adds trace-blinkgc profiler mode. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py	View	1 2	1 chunk	+5 lines, -4 lines	1 comment	Download
	M	tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py	View	1 2	1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

keishi

5 years, 11 months ago (2015-01-27 09:42:29 UTC) #1

https://codereview.chromium.org/745493002/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/745493002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:92: #raise
TracingTimeoutException(
I did this because when the trace data got large, dev tools stopped responding
and the tracing json file was not produced.
By not raising an exception, the partial tracing json data is written out.

https://codereview.chromium.org/745493002/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py (right):

https://codereview.chromium.org/745493002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py:78:
categories='blink_gc,webkit.console,benchmark,blink.console')
I added this to make the tracing json file smaller.

Expand Messages | Collapse Messages