Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: content/child/webcrypto/test/aes_gcm_unittest.cc

Issue 745443002: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/webcrypto/test/aes_cbc_unittest.cc ('k') | content/child/webcrypto/test/aes_kw_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/test/aes_gcm_unittest.cc
diff --git a/content/child/webcrypto/test/aes_gcm_unittest.cc b/content/child/webcrypto/test/aes_gcm_unittest.cc
index 03464145f88948b2b593812faf88486eebcdaada..2c2046fc1258c56f1f345826c01abdcb4d622fe2 100644
--- a/content/child/webcrypto/test/aes_gcm_unittest.cc
+++ b/content/child/webcrypto/test/aes_gcm_unittest.cc
@@ -113,11 +113,22 @@ TEST(WebCryptoAesGcmTest, GenerateKeyBadLength) {
for (size_t i = 0; i < arraysize(kKeyLen); ++i) {
SCOPED_TRACE(i);
EXPECT_EQ(Status::ErrorGenerateKeyLength(),
- GenerateSecretKey(
- CreateAesGcmKeyGenAlgorithm(kKeyLen[i]), true, 0, &key));
+ GenerateSecretKey(CreateAesGcmKeyGenAlgorithm(kKeyLen[i]), true,
+ blink::WebCryptoKeyUsageDecrypt, &key));
}
}
+TEST(WebCryptoAesGcmTest, GenerateKeyEmptyUsage) {
+ if (!SupportsAesGcm()) {
+ LOG(WARNING) << "AES GCM not supported, skipping tests";
+ return;
+ }
+
+ blink::WebCryptoKey key;
+ EXPECT_EQ(Status::ErrorCreateKeyEmptyUsages(),
+ GenerateSecretKey(CreateAesGcmKeyGenAlgorithm(256), true, 0, &key));
+}
+
TEST(WebCryptoAesGcmTest, ImportExportJwk) {
// Some Linux test runners may not have a new enough version of NSS.
if (!SupportsAesGcm()) {
« no previous file with comments | « content/child/webcrypto/test/aes_cbc_unittest.cc ('k') | content/child/webcrypto/test/aes_kw_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698