Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/child/webcrypto/test/ecdsa_unittest.cc

Issue 745443002: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more tests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/test/ecdsa_unittest.cc
diff --git a/content/child/webcrypto/test/ecdsa_unittest.cc b/content/child/webcrypto/test/ecdsa_unittest.cc
index 0ffbb8823a65c27d1415af1d2c83f198f71bc118..ed779f5b4c164590298330c88ac58048115fe32c 100644
--- a/content/child/webcrypto/test/ecdsa_unittest.cc
+++ b/content/child/webcrypto/test/ecdsa_unittest.cc
@@ -85,7 +85,8 @@ TEST(WebCryptoEcdsaTest, GenerateKeyIsRandom) {
blink::WebCryptoKey private_key;
ASSERT_EQ(Status::Success(),
- GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true, 0,
+ GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true,
+ blink::WebCryptoKeyUsageSign,
&public_key, &private_key));
// Basic sanity checks on the generated key pair.
@@ -110,6 +111,19 @@ TEST(WebCryptoEcdsaTest, GenerateKeyIsRandom) {
EXPECT_FALSE(CopiesExist(serialized_keys));
}
+TEST(WebCryptoEcdsaTest, GenerateKeyEmptyUsage) {
+ if (!SupportsEcdsa())
+ return;
+
+ blink::WebCryptoNamedCurve named_curve = blink::WebCryptoNamedCurveP256;
+ blink::WebCryptoKey public_key;
+ blink::WebCryptoKey private_key;
+ ASSERT_EQ(Status::ErrorCreateKeyBadUsages(),
+ GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true,
+ 0, &public_key, &private_key));
+
+}
+
// Verify that ECDSA signatures are probabilistic. Signing the same message two
// times should yield different signatures. However both signatures should
// verify correctly.

Powered by Google App Engine
This is Rietveld 408576698