content/child/webcrypto/openssl/sym_key_openssl.cc - Issue 745443002: Check that usage isn't empty when generateKey() is called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/openssl/sym_key_openssl.cc

Issue 745443002: Check that usage isn't empty when generateKey() is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/webcrypto/nss/sym_key_nss.cc ('K') | « content/child/webcrypto/nss/sym_key_nss.cc ('k') | content/child/webcrypto/openssl/util_openssl.cc » ('j') | content/child/webcrypto/openssl/util_openssl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/webcrypto/openssl/sym_key_openssl.cc

diff --git a/content/child/webcrypto/openssl/sym_key_openssl.cc b/content/child/webcrypto/openssl/sym_key_openssl.cc

index 39238335a26677fa9e3cb96d1872f80508131d62..56be578928bb5796c541e905ca846e53654177a6 100644

--- a/content/child/webcrypto/openssl/sym_key_openssl.cc

+++ b/content/child/webcrypto/openssl/sym_key_openssl.cc

@@ -32,6 +32,10 @@ Status GenerateSecretKeyOpenSsl(const blink::WebCryptoKeyAlgorithm& algorithm,

return Status::OperationError();

}

+ if (usages == 0) {

eroman 2014/11/20 23:40:10 Move this higher up -- should fail fast before doi

nharper 2014/11/21 22:12:01 Done.

+ return Status::ErrorCreateKeyBadUsages();

+ }

result->AssignSecretKey(

blink::WebCryptoKey::create(new SymKeyOpenSsl(CryptoData(random_bytes)),

blink::WebCryptoKeyTypeSecret,