Source/core/rendering/svg/RenderSVGRect.h - Issue 745383007: Fix an issue where hit detection could fail on rect and ellipse shapes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGRect.h

Issue 745383007: Fix an issue where hit detection could fail on rect and ellipse shapes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address test failures Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/RenderSVGRect.h

diff --git a/Source/core/rendering/svg/RenderSVGRect.h b/Source/core/rendering/svg/RenderSVGRect.h

index 4703e4d23e30e587c68ab111d20074e4618365fc..e040202124f9d794fe3111b5b81cc95ccf8cd2d7 100644

--- a/Source/core/rendering/svg/RenderSVGRect.h

+++ b/Source/core/rendering/svg/RenderSVGRect.h

@@ -46,6 +46,7 @@ private:

virtual bool isShapeEmpty() const override { return m_usePathFallback ? RenderSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }

virtual bool shapeDependentStrokeContains(const FloatPoint&) override;

virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const override;

+ bool definitelyHasSimpleStroke() const;

private:

FloatRect m_innerStrokeRect;

« no previous file with comments | « Source/core/rendering/svg/RenderSVGEllipse.cpp ('k') | Source/core/rendering/svg/RenderSVGRect.cpp » ('j') | no next file with comments »