Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Unified Diff: Source/core/rendering/svg/RenderSVGEllipse.h

Issue 745383007: Fix an issue where hit detection could fail on rect and ellipse shapes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/RenderSVGEllipse.h
diff --git a/Source/core/rendering/svg/RenderSVGEllipse.h b/Source/core/rendering/svg/RenderSVGEllipse.h
index dc31a07233b8846a77af38c7ab969f1e6e668543..436f39531ee7f73f3ef5c845c296598b557f9dbf 100644
--- a/Source/core/rendering/svg/RenderSVGEllipse.h
+++ b/Source/core/rendering/svg/RenderSVGEllipse.h
@@ -38,14 +38,17 @@ public:
virtual ShapeGeometryCodePath geometryCodePath() const override { return m_usePathFallback ? PathGeometry : EllipseGeometryFastPath; }
-private:
virtual const char* renderName() const override { return "RenderSVGEllipse"; }
+protected:
fs 2014/12/04 13:10:35 Please restore the access specifiers ('protected'
virtual void updateShapeFromElement() override;
virtual bool isShapeEmpty() const override { return m_usePathFallback ? RenderSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }
virtual bool shapeDependentStrokeContains(const FloatPoint&) override;
virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const override;
+
+private:
void calculateRadiiAndCenter();
+ bool hasContinuousStroke() const;
private:
FloatPoint m_center;

Powered by Google App Engine
This is Rietveld 408576698