Fix an issue where hit detection could fail on rect and ellipse shapes

Source/core/rendering/svg/RenderSVGRect.cpp

 /*
  * Copyright (C) 2011 University of Szeged
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 44 matching lines @@
 
     SVGLengthContext lengthContext(rect);
     FloatSize boundingBoxSize(rect->width()->currentValue()->value(lengthContext), rect->height()->currentValue()->value(lengthContext));
 
     // Spec: "A negative value is an error."
     if (boundingBoxSize.width() < 0 || boundingBoxSize.height() < 0)
         return;
 
     // Spec: "A value of zero disables rendering of the element."
     if (!boundingBoxSize.isEmpty()) {
-        // Fallback to RenderSVGShape if rect has rounded corners or a non-scaling stroke.
-        if (rect->rx()->currentValue()->value(lengthContext) > 0 || rect->ry()->currentValue()->value(lengthContext) > 0 || hasNonScalingStroke()) {
+        // Fallback to RenderSVGShape and path-based hit detection if the rect
+        // has rounded corners or a non-scaling or non-simple stroke.
+        if (rect->rx()->currentValue()->value(lengthContext) > 0
+            || rect->ry()->currentValue()->value(lengthContext) > 0
+            || hasNonScalingStroke()
+            || !hasSimpleStroke()) {
             RenderSVGShape::updateShapeFromElement();
             m_usePathFallback = true;
             return;
         }
     }
 
     m_fillBoundingBox = FloatRect(FloatPoint(rect->x()->currentValue()->value(lengthContext), rect->y()->currentValue()->value(lengthContext)), boundingBoxSize);
 
     // To decide if the stroke contains a point we create two rects which represent the inner and
     // the outer stroke borders. A stroke contains the point, if the point is between them.
     m_innerStrokeRect = m_fillBoundingBox;
     m_outerStrokeRect = m_fillBoundingBox;
 
     if (style()->svgStyle().hasStroke()) {
         float strokeWidth = this->strokeWidth();
         m_innerStrokeRect.inflate(-strokeWidth / 2);
         m_outerStrokeRect.inflate(strokeWidth / 2);
     }
 
     m_strokeBoundingBox = m_outerStrokeRect;
 }
 
 bool RenderSVGRect::shapeDependentStrokeContains(const FloatPoint& point)
 {
     // The optimized contains code below does not support non-smooth strokes so we need
     // to fall back to RenderSVGShape::shapeDependentStrokeContains in these cases.
-    if (m_usePathFallback || !hasSmoothStroke()) {
+    if (m_usePathFallback || !hasSimpleStroke()) {
         if (!hasPath())
             RenderSVGShape::updateShapeFromElement();
         return RenderSVGShape::shapeDependentStrokeContains(point);
     }
 
     return m_outerStrokeRect.contains(point, FloatRect::InsideOrOnStroke) && !m_innerStrokeRect.contains(point, FloatRect::InsideButNotOnStroke);
 }
 
 bool RenderSVGRect::shapeDependentFillContains(const FloatPoint& point, const WindRule fillRule) const
 {
     if (m_usePathFallback)
         return RenderSVGShape::shapeDependentFillContains(point, fillRule);
     return m_fillBoundingBox.contains(point.x(), point.y());
 }
 
+bool RenderSVGRect::hasSimpleStroke() const
+{
+    const SVGRenderStyle& svgStyle = style()->svgStyle();
+    return svgStyle.strokeDashArray()->isEmpty()
+        && svgStyle.strokeMiterLimit() == SVGRenderStyle::initialStrokeMiterLimit()
+        && svgStyle.joinStyle() == SVGRenderStyle::initialJoinStyle();

[Erik Dahlström (inactive), 2014/12/04 14:25:48]

Here's an example where this might fail: http://jsfiddle.net/upqffmwa/

Since we have a rect (only 90 degree angles), I think it should return true if
stroke-linejoin==miter && stroke-miterlimit > 1.414 (approx.), as indicated in
the spec: http://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty. You
may wish to compute a more exact value for this.

 }
+
+}