Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: include/core/SkRefCnt.h

Issue 745383003: add some debugging to SkNVRefCnt (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix bench Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/RecordingBench.cpp ('k') | tests/PictureBBHTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkRefCnt.h
diff --git a/include/core/SkRefCnt.h b/include/core/SkRefCnt.h
index 1e31d918cc973727fcdf6b99b5d27a823bba478c..d85c20ecaf0638c233f38810ceb5581001208b77 100644
--- a/include/core/SkRefCnt.h
+++ b/include/core/SkRefCnt.h
@@ -261,10 +261,23 @@ public:
bool unique() const { return 1 == sk_acquire_load(&fRefCnt); }
void ref() const { sk_atomic_inc(&fRefCnt); }
- void unref() const { if (1 == sk_atomic_dec(&fRefCnt)) { SkDELETE((const Derived*)this); } }
+ void unref() const {
+ int32_t prevValue = sk_atomic_dec(&fRefCnt);
+ SkASSERT(prevValue >= 1);
+ if (1 == prevValue) {
+ SkDELETE((const Derived*)this);
+ }
+ }
void deref() const { this->unref(); } // Chrome prefers to call deref().
int32_t getRefCnt() const { return fRefCnt; } // Used by Chrome unit tests.
+protected:
+#ifdef SK_DEBUG
+ ~SkNVRefCnt() {
+ SkASSERTF(0 == fRefCnt, "NVRefCnt was %d", fRefCnt);
+ }
+#endif
+
private:
mutable int32_t fRefCnt;
};
« no previous file with comments | « bench/RecordingBench.cpp ('k') | tests/PictureBBHTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698