Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: Source/bindings/v8/Dictionary.h

Issue 74533003: Add Perl IDL support for method parameter type sequence<Dictionary> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Alternate approach using Vector<Dictionary> Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/Dictionary.h
diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h
index 27fea21e3156d98c2064dbaae22229f5a1a8f00e..7fbdbb7ebbee6407bebae6fb513fd05c5b10a055 100644
--- a/Source/bindings/v8/Dictionary.h
+++ b/Source/bindings/v8/Dictionary.h
@@ -55,7 +55,7 @@ class VoidCallback;
class Dictionary {
public:
Dictionary();
- Dictionary(const v8::Local<v8::Value>& options, v8::Isolate*);
+ Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*);
~Dictionary();
Dictionary& operator=(const Dictionary&);
@@ -103,12 +103,7 @@ public:
private:
bool getKey(const String& key, v8::Local<v8::Value>&) const;
- // This object can only be used safely when stack allocated because of v8::Local.
- static void* operator new(size_t);
- static void* operator new[](size_t);
- static void operator delete(void *);
haraken 2013/11/19 11:12:05 Instead of removing these, won't the following cod
alancutter (OOO until 2018) 2013/11/20 00:40:14 Done.
-
- v8::Local<v8::Value> m_options;
+ v8::Handle<v8::Value> m_options;
v8::Isolate* m_isolate;
};

Powered by Google App Engine
This is Rietveld 408576698