Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: Source/bindings/v8/Dictionary.h

Issue 74533003: Add Perl IDL support for method parameter type sequence<Dictionary> (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review changes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/Dictionary.h
diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h
index 27fea21e3156d98c2064dbaae22229f5a1a8f00e..2d50a037606f3f40115eaa924e05a331849f3a67 100644
--- a/Source/bindings/v8/Dictionary.h
+++ b/Source/bindings/v8/Dictionary.h
@@ -55,7 +55,7 @@ class VoidCallback;
class Dictionary {
public:
Dictionary();
- Dictionary(const v8::Local<v8::Value>& options, v8::Isolate*);
+ Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*);
~Dictionary();
Dictionary& operator=(const Dictionary&);
@@ -100,15 +100,16 @@ public:
bool getWithUndefinedOrNullCheck(const String&, String&) const;
+ // Only allow inline allocation.
+ void* operator new(size_t, NotNullTag, void* location) { return location; }
+
private:
- bool getKey(const String& key, v8::Local<v8::Value>&) const;
+ // Disallow new allocation.
+ void* operator new(size_t);
- // This object can only be used safely when stack allocated because of v8::Local.
- static void* operator new(size_t);
- static void* operator new[](size_t);
- static void operator delete(void *);
+ bool getKey(const String& key, v8::Local<v8::Value>&) const;
- v8::Local<v8::Value> m_options;
+ v8::Handle<v8::Value> m_options;
v8::Isolate* m_isolate;
};
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698