Add Perl IDL support for method parameter type sequence<Dictionary>

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 422 matching lines @@
     } elsif ($type eq "any" || IsCallbackFunctionType($type)) {
         AddToImplIncludes("bindings/v8/ScriptValue.h");
     } elsif ($type eq "Promise") {
         AddToImplIncludes("bindings/v8/ScriptPromise.h");
     } elsif ($type eq "EventHandler") {
         AddToImplIncludes("bindings/v8/V8AbstractEventListener.h");
         AddToImplIncludes("bindings/v8/V8EventListenerList.h");
     } elsif (IsTypedArrayType($type)) {
         AddToImplIncludes("bindings/v8/custom/V8${type}Custom.h");
     } elsif (my $arrayType = GetArrayType($type)) {
-        AddIncludesForType($arrayType);
+        if (IsDictionaryType($arrayType)) {

[Nils Barth (inactive), 2013/11/19 06:45:43]

I think you can just add:
} elsif ($type eq "Dictionary") {
    AddToImplIncludes("bindings/v8/Dictionary.h");
}
in the main elsif sequence.

[alancutter (OOO until 2018), 2013/11/19 11:00:44]

Done.

+            AddToImplIncludes("bindings/v8/Dictionary.h");
+        } else {
+            AddIncludesForType($arrayType);
+        }
     } else {
         AddToImplIncludes("V8${type}.h");
     }
 }
 
 sub HeaderFilesForInterface
 {
     my $interfaceName = shift;
     my $implClassName = shift;
 
@@ skipping 4843 matching lines @@
     }
 
     return "String" if $type eq "DOMString" or IsEnumType($type);
 
     return "ScriptPromise" if $type eq "Promise";
 
     return "Range::CompareHow" if $type eq "CompareHow";
     return "DOMTimeStamp" if $type eq "DOMTimeStamp";
     return "double" if $type eq "Date";
     return "ScriptValue" if $type eq "any" or IsCallbackFunctionType($type);
-    return "Dictionary" if $type eq "Dictionary";
+    return "Dictionary" if IsDictionaryType($type);
 
     die "UnionType is not supported" if IsUnionType($type);
 
     if (IsTypedArrayType($type)) {
         return $isParameter ? "${type}*" : "RefPtr<${type}>";
     }
 
     # We need to check [ImplementedAs] extended attribute for wrapper types.
     return "RefPtr<$type>" if $type eq "XPathNSResolver";  # FIXME: can this be put in nonWrapperTypes instead?
     if (IsWrapperType($type)) {
         my $interface = ParseInterface($type);
         my $implClassName = GetImplName($interface);
         return $isParameter ? "${implClassName}*" : "RefPtr<${implClassName}>";
     }
     return "RefPtr<$type>" if IsRefPtrType($type) and (not $isParameter or $nonWrapperTypes{$type});
 
     my $arrayOrSequenceType = GetArrayOrSequenceType($type);
 
     if ($arrayOrSequenceType) {
         my $nativeType = GetNativeType($arrayOrSequenceType);
         $nativeType .= " " if ($nativeType =~ />$/);
+        return "DictionarySequence" if IsDictionaryType($nativeType);
         return "Vector<${nativeType}>";
     }
 
     # Default, assume native type is a pointer with same type name as idl type
     return "${type}*";
 }
 
 sub GetNativeTypeForCallbacks
 {
     my $type = shift;
@@ skipping 73 matching lines @@
 
     if ($type eq "DOMString" or IsEnumType($type)) {
         return $value;
     }
 
     if ($type eq "SerializedScriptValue") {
         AddToImplIncludes("bindings/v8/SerializedScriptValue.h");
         return "SerializedScriptValue::create($value, $getIsolate)";
     }
 
-    if ($type eq "Dictionary") {
+    if (IsDictionaryType($type)) {
         AddToImplIncludes("bindings/v8/Dictionary.h");
         return "Dictionary($value, $getIsolate)";
     }
 
     if ($type eq "any" || IsCallbackFunctionType($type)) {
         AddToImplIncludes("bindings/v8/ScriptValue.h");
         return "ScriptValue($value, $getIsolate)";
     }
 
     if ($type eq "Promise") {
@@ skipping 19 matching lines @@
         return "$value->Is${type}() ? V8${type}::toNative(v8::Handle<v8::${type}>::Cast($value)) : 0"
     }
 
     if ($type eq "XPathNSResolver") {
         return "toXPathNSResolver($value, $getIsolate)";
     }
 
     my $arrayOrSequenceType = GetArrayOrSequenceType($type);
 
     if ($arrayOrSequenceType) {
+        if (IsDictionaryType($arrayOrSequenceType)) {
+            return "toDictionarySequence($value, $argIndexOrZero, $getIsolate)";
+        }
         if (IsRefPtrType($arrayOrSequenceType)) {
             AddToImplIncludes("V8${arrayOrSequenceType}.h");
             return "(toRefPtrNativeArray<${arrayOrSequenceType}, V8${arrayOrSequenceType}>($value, $argIndexOrZero, $getIsolate))";
         }
         return "toNativeArray<" . GetNativeType($arrayOrSequenceType) . ">($value, $argIndexOrZero, $getIsolate)";
     }
 
     AddIncludesForType($type);
 
     AddToImplIncludes("V8${type}.h");
@@ skipping 464 matching lines @@
 }
 
 sub IsEnumType
 {
     my $type = shift;
 
     return 1 if $enumTypeHash{$type};
     return 0;
 }
 
+sub IsDictionaryType

[Nils Barth (inactive), 2013/11/19 06:45:43]

This subroutine doesn't add anything, and is less clear than just inline
$type eq "Dictionary"

Are you planning to add more logic here?
If not, could you just inline $type eq "Dictionary" instead?

[alancutter (OOO until 2018), 2013/11/19 11:00:44]

Done.

+{
+    my $type = shift;
+
+    return $type eq "Dictionary";
+}
+
 sub ValidEnumValues
 {
     my $type = shift;
 
     return @{$enumTypeHash{$type}};
 }
 
 sub IsSVGTypeNeedingTearOff
 {
     my $type = shift;
@@ skipping 354 matching lines @@
     my $interface = shift;
 
     return 1 if $interface->extendedAttributes->{"CustomToV8"};
     return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
     return 1 if InheritsInterface($interface, "Document");
 
     return 0;
 }
 
 1;