Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: sdk/lib/_internal/pub_generated/test/global/binstubs/outdated_binstub_runs_pub_global_test.dart

Issue 745153002: Make pub's binstubs resilient to changes in snapshot format. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/test/global/binstubs/outdated_binstub_runs_pub_global_test.dart
diff --git a/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart b/sdk/lib/_internal/pub_generated/test/global/binstubs/outdated_binstub_runs_pub_global_test.dart
similarity index 53%
copy from sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
copy to sdk/lib/_internal/pub_generated/test/global/binstubs/outdated_binstub_runs_pub_global_test.dart
index 271759867a88d448e71b1b214942452b35e04b2a..48da7f985e040d65ffd1572ce29ccc8c15915acb 100644
--- a/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
+++ b/sdk/lib/_internal/pub_generated/test/global/binstubs/outdated_binstub_runs_pub_global_test.dart
@@ -2,6 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'dart:io';
+
+import 'package:path/path.dart' as p;
+import 'package:scheduled_test/scheduled_process.dart';
+import 'package:scheduled_test/scheduled_stream.dart';
import 'package:scheduled_test/scheduled_test.dart';
import '../../descriptor.dart' as d;
@@ -10,7 +15,7 @@ import 'utils.dart';
main() {
initConfig();
- integration("the binstubs runs a precompiled snapshot if present", () {
+ integration("an outdated binstub runs 'pub global run'", () {
servePackages((builder) {
builder.serve("foo", "1.0.0", pubspec: {
"executables": {
@@ -27,10 +32,18 @@ main() {
cachePath,
[
d.dir(
- "bin",
+ 'global_packages',
[
- d.matcherFile(
- binStubName("foo-script"),
- contains("script.dart.snapshot"))])]).validate();
+ d.dir(
+ 'foo',
+ [d.dir('bin', [d.outOfDateSnapshot('script.dart.snapshot')])])])]).create();
+
+ var process = new ScheduledProcess.start(
+ p.join(sandboxDir, cachePath, "bin", binStubName("foo-script")),
+ ["arg1", "arg2"],
+ environment: getEnvironment());
+
+ process.stdout.expect(consumeThrough("ok"));
+ process.shouldExit();
});
}

Powered by Google App Engine
This is Rietveld 408576698