sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart - Issue 745153002: Make pub's binstubs resilient to changes in snapshot format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart

Issue 745153002: Make pub's binstubs resilient to changes in snapshot format. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub_generated/test/global/activate/outdated_binstub_test.dart ('k') | sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_global_run_if_no_snapshot_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart

diff --git a/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart b/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart

index 5bb8e86c28f589e53e16cbae12c4fbcc30b90d94..314c2e5a85b0249000a09f5467f4a81b7d88a0b2 100644

--- a/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart

+++ b/sdk/lib/_internal/pub_generated/test/global/binstubs/binstub_runs_executable_test.dart

@@ -58,16 +58,3 @@ main() {

process.shouldExit();

});

}

-/// The buildbots do not have the Dart SDK (containing "dart" and "pub") on

-/// their PATH, so we need to spawn the binstub process with a PATH that

-/// explicitly includes it.

-getEnvironment() {

- var binDir = p.dirname(Platform.executable);

- var separator = Platform.operatingSystem == "windows" ? ";" : ":";

- var path = "${Platform.environment["PATH"]}$separator$binDir";

- var environment = getPubTestEnvironment();

- environment["PATH"] = path;

- return environment;