sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart - Issue 745153002: Make pub's binstubs resilient to changes in snapshot format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart

Issue 745153002: Make pub's binstubs resilient to changes in snapshot format. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub_generated/lib/src/command/cache_repair.dart ('k') | sdk/lib/_internal/pub_generated/lib/src/global_packages.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart

diff --git a/sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart b/sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart

index ee16741b513fcba1edeb188f443270d51a07b9f7..b9fd11f7b7e7a1c58b7870e6f83a91ca1a11b8ac 100644

--- a/sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart

+++ b/sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart

@@ -562,6 +562,10 @@ class Entrypoint {

/// contains dependencies that are not in the lockfile or that don't match

/// what's in there.

bool _isLockFileUpToDate(LockFile lockFile) {

+ /// If this is an entrypoint for an in-memory package, trust the in-memory

+ /// lockfile provided for it.

+ if (root.dir == null) return true;

return root.immediateDependencies.every((package) {

var locked = lockFile.packages[package.name];

if (locked == null) return false;