Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: sdk/lib/_internal/pub/test/global/activate/outdated_binstub_test.dart

Issue 745153002: Make pub's binstubs resilient to changes in snapshot format. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/global/activate/outdated_binstub_test.dart
diff --git a/sdk/lib/_internal/pub/test/global/activate/outdated_binstub_test.dart b/sdk/lib/_internal/pub/test/global/activate/outdated_binstub_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..51bcc837bab0a730a4f8c0f2c39c29d3ee454e19
--- /dev/null
+++ b/sdk/lib/_internal/pub/test/global/activate/outdated_binstub_test.dart
@@ -0,0 +1,58 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';
+import 'dart:async';
+
+import 'package:path/path.dart' as p;
+import 'package:scheduled_test/scheduled_process.dart';
+import 'package:scheduled_test/scheduled_stream.dart';
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../../descriptor.dart' as d;
+import '../../test_pub.dart';
+
+const _OUTDATED_BINSTUB = """
+#!/usr/bin/env sh
+# This file was created by pub v0.1.2-3.
+# Package: foo
+# Version: 1.0.0
+# Executable: foo-script
+# Script: script
+dart "/path/to/.pub-cache/global_packages/foo/bin/script.dart.snapshot" "\$@"
+""";
+
+main() {
+ initConfig();
+ integration("an outdated binstub is replaced", () {
+ servePackages((builder) {
+ builder.serve("foo", "1.0.0", pubspec: {
+ "executables": {
+ "foo-script": "script"
+ }
+ }, contents: [
+ d.dir("bin", [
+ d.file("script.dart", "main(args) => print('ok \$args');")
+ ])
+ ]);
+ });
+
+ schedulePub(args: ["global", "activate", "foo"]);
+
+ d.dir(cachePath, [
+ d.dir('bin', [
+ d.file(binStubName('foo-script'), _OUTDATED_BINSTUB)
+ ])
+ ]).create();
+
+ schedulePub(args: ["global", "activate", "foo"]);
+
+ d.dir(cachePath, [
+ d.dir('bin', [
+ // 255 is the VM's exit code upon seeing an out-of-date snapshot.
+ d.matcherFile(binStubName('foo-script'), contains("255"))
+ ])
+ ]).validate();
+ });
+}

Powered by Google App Engine
This is Rietveld 408576698