Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: sdk/lib/_internal/pub/test/cache/repair/handles_corrupted_binstub_test.dart

Issue 745153002: Make pub's binstubs resilient to changes in snapshot format. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/cache/repair/handles_corrupted_binstub_test.dart
diff --git a/sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart b/sdk/lib/_internal/pub/test/cache/repair/handles_corrupted_binstub_test.dart
similarity index 62%
copy from sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
copy to sdk/lib/_internal/pub/test/cache/repair/handles_corrupted_binstub_test.dart
index 3d704e73edb02ecbecdc157043ff0121037fbe16..5af3b4703f3cca5ba4eaf1f3c8200a7a244e428a 100644
--- a/sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
+++ b/sdk/lib/_internal/pub/test/cache/repair/handles_corrupted_binstub_test.dart
@@ -2,21 +2,20 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+library pub_tests;
+
+import 'dart:io';
+
import 'package:scheduled_test/scheduled_test.dart';
import '../../descriptor.dart' as d;
import '../../test_pub.dart';
-import 'utils.dart';
main() {
initConfig();
- integration("the binstubs runs a precompiled snapshot if present", () {
+ integration('handles a corrupted binstub script', () {
servePackages((builder) {
- builder.serve("foo", "1.0.0", pubspec: {
- "executables": {
- "foo-script": "script"
- }
- }, contents: [
+ builder.serve("foo", "1.0.0", contents: [
d.dir("bin", [
d.file("script.dart", "main(args) => print('ok');")
])
@@ -26,10 +25,12 @@ main() {
schedulePub(args: ["global", "activate", "foo"]);
d.dir(cachePath, [
- d.dir("bin", [
- d.matcherFile(binStubName("foo-script"),
- contains("script.dart.snapshot"))
+ d.dir('bin', [
+ d.file(binStubName('script'), 'junk')
])
- ]).validate();
+ ]).create();
+
+ schedulePub(args: ["cache", "repair"],
+ error: contains('Error reading binstub for "script":'));
});
}

Powered by Google App Engine
This is Rietveld 408576698