Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: sdk/lib/_internal/pub/test/global/binstubs/utils.dart

Issue 745153002: Make pub's binstubs resilient to changes in snapshot format. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async';
5 import 'dart:io'; 6 import 'dart:io';
6 7
7 /// Returns the name of the shell script for a binstub named [name]. 8 import 'package:path/path.dart' as p;
8 /// 9
9 /// Adds a ".bat" extension on Windows. 10 import '../../test_pub.dart';
10 binStubName(String name) { 11
11 if (Platform.operatingSystem == "windows") return "$name.bat"; 12 /// The buildbots do not have the Dart SDK (containing "dart" and "pub") on
12 return name; 13 /// their PATH, so we need to spawn the binstub process with a PATH that
14 /// explicitly includes it.
15 Future<Map> getEnvironment() async {
16 var binDir = p.dirname(Platform.executable);
17 var separator = Platform.operatingSystem == "windows" ? ";" : ":";
18 var path = "${Platform.environment["PATH"]}$separator$binDir";
19
20 var environment = await getPubTestEnvironment();
21 environment["PATH"] = path;
22 return environment;
13 } 23 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698