Moved text decoding to the parser thread

Source/core/dom/DecodedDataDocumentParser.h

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 15 matching lines @@
 #ifndef DecodedDataDocumentParser_h
 #define DecodedDataDocumentParser_h
 
 #include "core/dom/DocumentParser.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 class TextResourceDecoder;
 
 class DecodedDataDocumentParser : public DocumentParser {

[abarth-chromium, 2013/11/18 17:32:24]

I wonder if we should restructure how this class works.  The point of this class
before was to provide decoded data to its subclasses.  Now that you've got
HTMLDocumentParser overriding appendBytes, we should probably restructure how
this works.  What are the subclasses of this class?  Is it just the
HTMLDocumentParser and XMLDocumentParser?  If so, they probably should "have" an
object that manages the decoding rather than "being" an object that manages the
decoding.

[oystein (OOO til 10th of July), 2013/11/18 22:18:42]

It's used by those two plus the HTMLViewSourceParser, as far as I can tell. I'll
gladly shuffle this to be a component if it's still worth it.

 public:
     // Only used by the XMLDocumentParser to communicate back to
     // XMLHttpRequest if the responseXML was well formed.
     virtual bool wellFormed() const { return true; }
 
     // The below functions are used by DocumentWriter (the loader).
     virtual void appendBytes(const char* bytes, size_t length) OVERRIDE;
     virtual void flush() OVERRIDE;
-    virtual bool needsDecoder() const OVERRIDE { return !m_decoder; }
+    virtual bool needsDecoder() const OVERRIDE { return m_needsDecoder; }
     virtual void setDecoder(PassOwnPtr<TextResourceDecoder>) OVERRIDE;
     virtual TextResourceDecoder* decoder() OVERRIDE;
     virtual void setHasAppendedData() OVERRIDE;
 
+    PassOwnPtr<TextResourceDecoder> adoptDecoder();
+
 protected:
     explicit DecodedDataDocumentParser(Document*);
     virtual ~DecodedDataDocumentParser();
 
 private:
     // append is used by DocumentWriter::replaceDocument.
     virtual void append(PassRefPtr<StringImpl>) = 0;
 
     void updateDocument(String& decodedData);
 
     bool m_hasAppendedData;
+    bool m_needsDecoder;
     OwnPtr<TextResourceDecoder> m_decoder;
 };
 
 }
 
 #endif // DecodedDataDocumentParser_h