extensions/shell/browser/shell_app_delegate.cc - Issue 745093002: AppShell support for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 745093002: AppShell support for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unittests too Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_app_delegate.cc

diff --git a/extensions/shell/browser/shell_app_delegate.cc b/extensions/shell/browser/shell_app_delegate.cc

index 1e2d5ddb8d24637f0459ad04a7a21668c1ffc4f7..36fc7502a874f9b0f695b8f6f1838dc0c70c4363 100644

--- a/extensions/shell/browser/shell_app_delegate.cc

+++ b/extensions/shell/browser/shell_app_delegate.cc

@@ -91,7 +91,6 @@ bool ShellAppDelegate::IsWebContentsVisible(

void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {

// TODO(jamescook): Should app_shell continue to close the app window

// manually or should it use a browser termination callback like Chrome?

- NOTIMPLEMENTED();

Yoyo Zhou 2014/12/10 02:18:19 I kept hitting this in tests. Since there's a TODO

}

void ShellAppDelegate::RenderViewCreated(