AppShell support for Mac.

extensions/shell/browser/shell_browser_main_parts_mac.mm

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/shell/browser/shell_browser_main_parts.h"
+
+#import "content/shell/browser/shell_application_mac.h"
+
+namespace extensions {
+
+void ShellBrowserMainParts::PreMainMessageLoopStart() {

[James Cook, 2014/12/10 21:05:01]

Rather than splitting the implementation of this class across two files, what do
you think about having something like this?

ShellBrowserMainParts::PreMainMessageLoopStart() {
#if defined(OS_MACOSX)
  PreMainMessageLoopStartMac();
#else
  ...other stuff...
#endif
}

and put a utility function here?

[Yoyo Zhou, 2014/12/11 02:40:50]

I don't think we can have the Mac and non-Mac implementations in the same file,
unfortunately. This one has to be a .mm (ObjC) because it calls ObjC code. The
other platforms don't compile ObjC.

[James Cook, 2014/12/11 20:08:28]

What I meant was to keep this implementation here, but put it in a utility
function like PreMainMessageLoopStartMac(). Then call it from
ShellBrowserMainParts::PreMainMessageLoopStart(). I find it confusing when
there's a class with most of the methods implemented in one file, but one or two
of them implemented elsewhere.

[Yoyo Zhou, 2014/12/16 01:11:19]

Ok. I like that suggestion.

+  // Force the NSApplication subclass to be used.
+  [ShellCrApplication sharedApplication];
+}
+
+}  // namespace extensions