Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 745053002: Grant access to files in PageState, which have already been validated. (Closed)

Created:
6 years, 1 month ago by Charlie Reis
Modified:
6 years ago
Reviewers:
sky, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Grant access to files in PageState, which have already been validated. BUG=262948 TEST=Go back (cross-process) to a page with a file selected to upload. Committed: https://crrev.com/e1d3e5b067465db7fccdfa0bfa5f5ffd9784c53b Cr-Commit-Position: refs/heads/master@{#306209}

Patch Set 1 #

Patch Set 2 : Add test and fix UpdateState #

Patch Set 3 : Formatting #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -21 lines) Patch
M chrome/browser/sessions/session_restore.cc View 1 1 chunk +0 lines, -13 lines 1 comment Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 2 3 chunks +85 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +13 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 1 chunk +3 lines, -5 lines 1 comment Download
A content/test/data/file_input.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Charlie Reis
https://codereview.chromium.org/745053002/diff/60001/chrome/browser/sessions/session_restore.cc File chrome/browser/sessions/session_restore.cc (left): https://codereview.chromium.org/745053002/diff/60001/chrome/browser/sessions/session_restore.cc#oldcode1085 chrome/browser/sessions/session_restore.cc:1085: // Set up the file access rights for the ...
6 years ago (2014-11-25 21:00:55 UTC) #3
nasko
LGTM
6 years ago (2014-11-25 22:56:20 UTC) #4
Charlie Reis
Thanks! +sky@ for OWNERS for session_restore.cc.
6 years ago (2014-11-25 23:10:49 UTC) #5
Charlie Reis
Actually +sky this time.
6 years ago (2014-11-25 23:11:04 UTC) #7
sky
LGTM
6 years ago (2014-12-01 16:49:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745053002/60001
6 years ago (2014-12-01 17:02:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years ago (2014-12-01 18:22:05 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-01 18:22:55 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1d3e5b067465db7fccdfa0bfa5f5ffd9784c53b
Cr-Commit-Position: refs/heads/master@{#306209}

Powered by Google App Engine
This is Rietveld 408576698