Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 745043002: Implement future sync points in gpu service (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
piman
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Implement future sync points in gpu service This adds a |retire| parameter to InsertSyncPoint and adds a RetireSyncPoint call so future sync points (which do not implicitly retire on insertion) can work. R=piman@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e24b02460c0d2e39d1427688805811d2ffa2ad3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M mojo/gles2/command_buffer_client_impl.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M mojo/services/public/interfaces/gpu/command_buffer.mojom View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
abarth@ - I lied to you slightly about how future sync points work. They don't ...
6 years, 1 month ago (2014-11-20 22:17:56 UTC) #1
piman
LGTM, but keep in mind that future sync points can allow untrusted code to create ...
6 years, 1 month ago (2014-11-20 22:52:59 UTC) #2
jamesr
Good point. Filed https://code.google.com/p/chromium/issues/detail?id=435641 to make sure we don't forget it. I think the implementation ...
6 years, 1 month ago (2014-11-21 19:04:04 UTC) #3
jamesr
6 years, 1 month ago (2014-11-21 19:04:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e24b02460c0d2e39d1427688805811d2ffa2ad3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698