Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/tools/apptest_runner.py

Issue 744973002: Pass command line args to apptests (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebase and address comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/cpp/application/lib/application_test_main.cc ('K') | « mojo/services/view_manager/view_manager_service_apptest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/apptest_runner.py
diff --git a/mojo/tools/apptest_runner.py b/mojo/tools/apptest_runner.py
index d84dd234af44f0eaf755d47211a7f703f39ad357..a0b524570a84c16b2fa714aa692160cc112a991e 100755
--- a/mojo/tools/apptest_runner.py
+++ b/mojo/tools/apptest_runner.py
@@ -64,7 +64,12 @@ def main(argv):
test_list = gtest_list_tests(list_output)
for test in test_list:
- command_line = [mojo_shell, apptest + " --gtest_filter=" + test]
+ # TODO(msw): enable passing arguments to tests down from the test harness.
+ command_line = [
+ mojo_shell,
+ "--args-for={0} --example_apptest_arg --gtest_filter={1}".format(
+ apptest, test),
+ apptest]
_logging.debug("Running %s..." % command_line)
try:
« mojo/public/cpp/application/lib/application_test_main.cc ('K') | « mojo/services/view_manager/view_manager_service_apptest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698