Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: mojo/tools/apptest_runner.py

Issue 744973002: Pass command line args to apptests (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: switch to using --args-for to pass arguments to apptests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/tools/apptest_runner.py
diff --git a/mojo/tools/apptest_runner.py b/mojo/tools/apptest_runner.py
index d84dd234af44f0eaf755d47211a7f703f39ad357..a0b524570a84c16b2fa714aa692160cc112a991e 100755
--- a/mojo/tools/apptest_runner.py
+++ b/mojo/tools/apptest_runner.py
@@ -64,7 +64,12 @@ def main(argv):
test_list = gtest_list_tests(list_output)
for test in test_list:
- command_line = [mojo_shell, apptest + " --gtest_filter=" + test]
+ # TODO(msw): enable passing arguments to tests down from the test harness.
+ command_line = [
+ mojo_shell,
+ "--args-for={0} --example_apptest_arg --gtest_filter={1}".format(
msw 2014/11/22 18:23:39 Is this quoting correct? I think it should be --ar
Chris Masone 2014/11/22 20:14:44 Since the command isn't being interpreted by a she
msw 2014/11/22 21:46:54 I think you still want escaped quotes around the v
Chris Masone 2014/11/24 17:08:22 No, then you wind up with the quotes embedded in t
msw 2014/11/24 19:05:20 Odd, both quoting styles work with direct command
+ apptest, test),
+ apptest]
_logging.debug("Running %s..." % command_line)
try:

Powered by Google App Engine
This is Rietveld 408576698