Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: mojo/public/cpp/application/lib/application_test_main.cc

Issue 744973002: Pass command line args to apptests (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: switch to using --args-for to pass arguments to apptests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/c/system/main.h" 5 #include "mojo/public/c/system/main.h"
6 #include "mojo/public/cpp/application/application_delegate.h" 6 #include "mojo/public/cpp/application/application_delegate.h"
7 #include "mojo/public/cpp/application/application_impl.h" 7 #include "mojo/public/cpp/application/application_impl.h"
8 #include "mojo/public/cpp/application/application_test_base.h" 8 #include "mojo/public/cpp/application/application_test_base.h"
9 #include "mojo/public/cpp/environment/environment.h" 9 #include "mojo/public/cpp/environment/environment.h"
10 #include "mojo/public/cpp/environment/logging.h" 10 #include "mojo/public/cpp/environment/logging.h"
11 #include "mojo/public/cpp/system/message_pipe.h" 11 #include "mojo/public/cpp/system/message_pipe.h"
12 #include "mojo/public/cpp/utility/run_loop.h" 12 #include "mojo/public/cpp/utility/run_loop.h"
13 13
14 MojoResult MojoMain(MojoHandle shell_handle) { 14 MojoResult MojoMain(MojoHandle shell_handle) {
15 // An Environment instance is needed to construct run loops. 15 // An Environment instance is needed to construct run loops.
16 mojo::Environment environment; 16 mojo::Environment environment;
17 17
18 { 18 {
19 // This loop is used for init, and then destroyed before running tests. 19 // This loop is used for init, and then destroyed before running tests.
20 mojo::RunLoop run_loop; 20 mojo::RunLoop run_loop;
21 21
22 // Construct an ApplicationImpl just for the GTEST commandline arguments. 22 // Construct an ApplicationImpl just for the GTEST commandline arguments.
23 // GTEST command line arguments are supported amid application arguments: 23 // GTEST command line arguments are supported amid application arguments:
24 // $ mojo_shell 'mojo:example_apptests arg1 --gtest_filter=foo arg2' 24 // $ mojo_shell mojo:example_apptests \
25 // --args-for='mojo:example_apptests arg1 --gtest_filter=foo arg2'
25 mojo::ApplicationDelegate dummy_application_delegate; 26 mojo::ApplicationDelegate dummy_application_delegate;
26 mojo::ApplicationImpl app(&dummy_application_delegate, shell_handle); 27 mojo::ApplicationImpl app(&dummy_application_delegate, shell_handle);
27 MOJO_CHECK(app.WaitForInitialize()); 28 MOJO_CHECK(app.WaitForInitialize());
28 29
29 // InitGoogleTest expects (argc + 1) elements, including a terminating NULL. 30 // InitGoogleTest expects (argc + 1) elements, including a terminating NULL.
30 // It also removes GTEST arguments from |argv| and updates the |argc| count. 31 // It also removes GTEST arguments from |argv| and updates the |argc| count.
31 // TODO(msw): Provide tests access to these actual command line arguments. 32 // TODO(msw): Provide tests access to these actual command line arguments.
msw 2014/11/22 18:23:39 Remove this TODO now.
Chris Masone 2014/11/22 20:14:44 Done.
32 const std::vector<std::string>& args = app.args(); 33 const std::vector<std::string>& args = app.args();
33 MOJO_CHECK(args.size() < 34 MOJO_CHECK(args.size() <
34 static_cast<size_t>(std::numeric_limits<int>::max())); 35 static_cast<size_t>(std::numeric_limits<int>::max()));
35 int argc = static_cast<int>(args.size()); 36 int argc = static_cast<int>(args.size());
36 std::vector<const char*> argv(argc + 1); 37 std::vector<const char*> argv(argc + 1);
37 for (int i = 0; i < argc; ++i) 38 for (int i = 0; i < argc; ++i)
38 argv[i] = args[i].c_str(); 39 argv[i] = args[i].c_str();
39 argv[argc] = nullptr; 40 argv[argc] = nullptr;
40 41
41 testing::InitGoogleTest(&argc, const_cast<char**>(&(argv[0]))); 42 testing::InitGoogleTest(&argc, const_cast<char**>(&(argv[0])));
42 mojo::test::SetShellHandle(app.UnbindShell()); 43 mojo::test::SetShellHandle(app.UnbindShell());
44 mojo::test::InitializeArgs(argc, argv);
43 } 45 }
44 46
45 int result = RUN_ALL_TESTS(); 47 int result = RUN_ALL_TESTS();
46 48
47 shell_handle = mojo::test::PassShellHandle().release().value(); 49 shell_handle = mojo::test::PassShellHandle().release().value();
48 MojoResult close_result = MojoClose(shell_handle); 50 MojoResult close_result = MojoClose(shell_handle);
49 MOJO_CHECK(close_result == MOJO_RESULT_OK); 51 MOJO_CHECK(close_result == MOJO_RESULT_OK);
50 52
51 return (result == 0) ? MOJO_RESULT_OK : MOJO_RESULT_UNKNOWN; 53 return (result == 0) ? MOJO_RESULT_OK : MOJO_RESULT_UNKNOWN;
52 } 54 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698