Pass command line args to apptests

mojo/public/cpp/application/lib/application_test_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/application/application_test_base.h"
 
 #include "mojo/public/cpp/application/application_delegate.h"
 #include "mojo/public/cpp/application/application_impl.h"
 #include "mojo/public/cpp/environment/environment.h"
 #include "mojo/public/cpp/environment/logging.h"
 #include "mojo/public/cpp/system/message_pipe.h"
 
 namespace mojo {
 namespace test {
 
 namespace {
 
 // This shell handle is shared by multiple test application instances.
 MessagePipeHandle g_shell_handle;
+// Command-line args passed to the harness are available to any test

[msw, 2014/11/20 21:59:12]

The args are actually passed to the test application like this, right?
  $ mojo_shell "mojo:test_app passed_arg" not_passed_shell_arg
If so, consider revising the comment, perhaps something like "// Share the
application command-line arguments with multiple application tests."

+// application instance.
+Array<String> g_args;
 
 }  // namespace
 
 ScopedMessagePipeHandle PassShellHandle() {
   MOJO_CHECK(g_shell_handle.is_valid());
   ScopedMessagePipeHandle scoped_handle(g_shell_handle);
   g_shell_handle = MessagePipeHandle();
   return scoped_handle.Pass();
 }
 
 void SetShellHandle(ScopedMessagePipeHandle handle) {
   MOJO_CHECK(handle.is_valid());
   MOJO_CHECK(!g_shell_handle.is_valid());
   g_shell_handle = handle.release();
 }
 
+const Array<String>& Args() {

[msw, 2014/11/20 21:59:12]

nit: can this be inlined in the header as args()?

[Chris Masone, 2014/11/20 23:35:19]

I actually don't think so, as g_args is defined only here in the .cc file.

[msw, 2014/11/22 18:23:38]

Acknowledged.

+  return g_args;
+}
+
+void InitializeArgs(int argc, std::vector<const char*> argv) {
+  MOJO_CHECK(g_args.is_null());
+  for (const char* arg : argv) {
+    if (arg)

[msw, 2014/11/20 21:59:12]

When are these ever null?

[Chris Masone, 2014/11/20 23:35:19]

After processing by the gtest library, the last arg is. I could use a loop index
instead, if you'd rather, to only push_back() the first argc items.

[msw, 2014/11/22 18:23:38]

Ah, OK. This is fine as-is.

+      g_args.push_back(arg);
+  }
+}
+
 ApplicationTestBase::ApplicationTestBase(Array<String> args)
     : args_(args.Pass()), application_impl_(nullptr) {
 }
 
 ApplicationTestBase::~ApplicationTestBase() {
 }
 
 void ApplicationTestBase::SetUp() {
   // A run loop is needed for ApplicationImpl initialization and communication.
   Environment::InstantiateDefaultRunLoop();
 
   // New applications are constructed for each test to avoid persisting state.
   application_impl_ = new ApplicationImpl(GetApplicationDelegate(),
                                           PassShellHandle());
 
   // Fake application initialization with the given command line arguments.
   application_impl_->Initialize(args_.Clone());
 }
 
 void ApplicationTestBase::TearDown() {
   SetShellHandle(application_impl_->UnbindShell());
   delete application_impl_;
   Environment::DestroyDefaultRunLoop();
 }
 
 }  // namespace test
 }  // namespace mojo