Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 744943002: Add missing dependencies to the GYP build. (Closed)

Created:
6 years, 1 month ago by blundell
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing dependencies to the GYP build. Adds dependencies that local work on moving the location in which code from the Mojo repo is pulled in to Chromium shook out. Committed: https://crrev.com/75c75366d00f9f9a44e67beb9a31a0c5b1e038de Cr-Commit-Position: refs/heads/master@{#305192}

Patch Set 1 #

Patch Set 2 : Remove no-longer used dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/extensions/api/api_registration.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
blundell
gyp version! jam: //content rockot: //chrome/browser/extensions
6 years, 1 month ago (2014-11-20 20:44:15 UTC) #2
Ken Rockot(use gerrit already)
said path lgtm
6 years, 1 month ago (2014-11-20 20:46:16 UTC) #3
jam
lgtm
6 years, 1 month ago (2014-11-20 21:17:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744943002/1
6 years, 1 month ago (2014-11-20 21:40:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/84442) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/89185) android_aosp ...
6 years, 1 month ago (2014-11-20 21:46:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744943002/20001
6 years, 1 month ago (2014-11-21 09:17:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-21 10:08:32 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 10:09:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75c75366d00f9f9a44e67beb9a31a0c5b1e038de
Cr-Commit-Position: refs/heads/master@{#305192}

Powered by Google App Engine
This is Rietveld 408576698