Restore order to the universe.

Restore order to the universe.

R=friedman@chromium.org, navabi@google.com, smut@google.com, smut@chromium.org

NOTRY=true
NOTREECHECKS=True
^^^ tools/build is hosed due to pylint roll

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293040

[ghost stip (do not use), 2014-11-20 19:06:27]

ptal

[smut, 2014-11-20 19:07:57]

smut@google.com changed reviewers:
+ navabi@google.com, smut@google.com

[smut, 2014-11-20 19:07:58]

lgtm

[navabi, 2014-11-20 19:08:34]

lgtm

[ghost stip (do not use), 2014-11-20 19:08:48]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744913002/1

[friedman, 2014-11-20 19:10:46]

On 2014/11/20 19:09:51, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/744913002/1

Why?  No LGTM

[friedman, 2014-11-20 19:11:03]

On 2014/11/20 19:10:46, friedman wrote:
> On 2014/11/20 19:09:51, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/744913002/1
> 
> Why?  No LGTM

LGTM--

[commit-bot: I haz the power, 2014-11-20 19:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:11:33]

Presubmit check for 744913002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Pylint (526 files) (96.27s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module master.factory.drmemory_factory
E: 59,45: Undefined variable 'platform' (undefined-variable)


Presubmit checks took 97.1s to calculate.

[ghost stip (do not use), 2014-11-20 19:12:27]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744913002/1

[commit-bot: I haz the power, 2014-11-20 19:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:14:46]

Presubmit check for 744913002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Pylint (526 files) (105.05s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module master.factory.drmemory_factory
E: 59,45: Undefined variable 'platform' (undefined-variable)


Presubmit checks took 106.0s to calculate.

[ghost stip (do not use), 2014-11-20 19:17:39]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744913002/1

[commit-bot: I haz the power, 2014-11-20 19:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:19:34]

Presubmit check for 744913002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Pylint (526 files) (96.68s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module master.factory.drmemory_factory
E: 59,45: Undefined variable 'platform' (undefined-variable)


Presubmit checks took 97.5s to calculate.

[ghost stip (do not use), 2014-11-20 19:30:38]

Committed patchset #1 (id:1) manually as 293040.