Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 744843002: Added the aria-sort state to the accessibility tree. (Closed)

Created:
6 years, 1 month ago by nektarios
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the aria-sort state to the accessibility tree. R=dmazzoni BUG=434127 Committed: https://crrev.com/cfd26c4af6ab5bad930578a43f25ff0dafeeffb5 Cr-Commit-Position: refs/heads/master@{#315426}

Patch Set 1 #

Patch Set 2 : Exposed aria-sort attribute in IAccessible2. #

Patch Set 3 : Added Mac support and extended browser test. #

Patch Set 4 : Separated ARIA grid and HTML table tests. #

Total comments: 3

Patch Set 5 : Fixed reviewer's comments. #

Patch Set 6 : Added the correct expectations for Windows tests and a note in readme file. #

Patch Set 7 : Added Mac and Android test expectations. #

Patch Set 8 : Surfaced AXSortDirection attribute in Mac tests. #

Patch Set 9 : Fixed expectations for Android and Windows tests. #

Patch Set 10 : Fixed Mac and Windows test expectations. #

Patch Set 11 : Fixed indentation of the test output on Mac. #

Patch Set 12 : Fixed Android test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1093 lines, -166 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 3 chunks +24 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 5 2 chunks +23 lines, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 1 chunk +21 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-sort.html View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-aria-grid.html View 1 2 3 1 chunk +122 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-aria-grid-expected-android.txt View 1 2 3 4 5 6 1 chunk +91 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-aria-grid-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +121 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-aria-grid-expected-win.txt View 1 2 3 4 5 1 chunk +121 lines, -0 lines 0 comments Download
D content/test/data/accessibility/aria/aria-sort-expected-android.txt View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
D content/test/data/accessibility/aria/aria-sort-expected-mac.txt View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
D content/test/data/accessibility/aria/aria-sort-expected-win.txt View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-html-table.html View 1 2 3 1 chunk +148 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-html-table-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +101 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-html-table-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +135 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-sort-html-table-expected-win.txt View 1 2 3 4 5 6 7 8 9 1 chunk +135 lines, -0 lines 0 comments Download
D content/test/data/accessibility/html/readme.txt View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
A + content/test/data/accessibility/readme.txt View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
nektarios
6 years, 1 month ago (2014-11-20 17:21:30 UTC) #1
dmazzoni
Since we only have 32-bits for AXState, I'd prefer not to waste them on rare ...
6 years, 1 month ago (2014-11-20 17:25:50 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/744843002/diff/60001/content/browser/accessibility/browser_accessibility_cocoa.mm File content/browser/accessibility/browser_accessibility_cocoa.mm (right): https://codereview.chromium.org/744843002/diff/60001/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode785 content/browser/accessibility/browser_accessibility_cocoa.mm:785: case ui::AX_SORT_DIRECTION_Unsorted: enum should be all caps https://codereview.chromium.org/744843002/diff/60001/content/browser/accessibility/browser_accessibility_win.cc ...
5 years, 10 months ago (2015-01-27 18:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744843002/180001
5 years, 10 months ago (2015-02-06 22:20:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/31697)
5 years, 10 months ago (2015-02-06 23:35:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744843002/200001
5 years, 10 months ago (2015-02-07 01:23:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/53196)
5 years, 10 months ago (2015-02-07 04:02:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744843002/200001
5 years, 10 months ago (2015-02-09 16:09:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/53581)
5 years, 10 months ago (2015-02-09 18:06:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744843002/220001
5 years, 10 months ago (2015-02-09 21:39:41 UTC) #17
commit-bot: I haz the power
Committed patchset #12 (id:220001)
5 years, 10 months ago (2015-02-09 23:26:27 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 23:27:43 UTC) #19
Message was sent while issue was closed. 
Patchset 12 (id:??) landed as
https://crrev.com/cfd26c4af6ab5bad930578a43f25ff0dafeeffb5
Cr-Commit-Position: refs/heads/master@{#315426}

Powered by Google App Engine
This is Rietveld 408576698