Issue 744833002: Update Dr. Memory bot factories to fully handle a 3rd platform, MacOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 744833002: Update Dr. Memory bot factories to fully handle a 3rd platform, MacOS. (Closed)

Created:
6 years, 1 month ago by Derek Bruening

Modified:
6 years, 1 month ago

Reviewers:
zhaoqin1

CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Project:
tools

Visibility:
Public.

Update Dr. Memory bot factories to fully handle a 3rd platform, MacOS. Several functions assumed each bot was either Windows or Linux. TBR=zhaoqin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293034

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -11 lines)			Patch
	M	masters/master.client.drmemory/master.cfg	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	scripts/master/factory/drmemory_factory.py	View		5 chunks	+15 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r293034.