Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 744763002: Certificate Transparency: Remove an unnecessary boolean. (Closed)

Created:
6 years, 1 month ago by Eran Messeri
Modified:
6 years, 1 month ago
Reviewers:
agl, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Certificate Transparency: Remove an unnecessary boolean. BUG= Committed: https://crrev.com/1cd7715f47d0066d12c04fd83424dd427b12098e Cr-Commit-Position: refs/heads/master@{#305092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/net/packed_ct_ev_whitelist.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/packed_ct_ev_whitelist.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Eran Messeri
David, kindly review this small change to the EV whitelist unpacking code. It's covered by ...
6 years, 1 month ago (2014-11-20 16:36:09 UTC) #2
davidben
lgtm. I suppose this'll break if the whitelist gets down to zero. But then you ...
6 years, 1 month ago (2014-11-20 20:47:01 UTC) #3
Eran Messeri
On 2014/11/20 20:47:01, David Benjamin wrote: > lgtm. I suppose this'll break if the whitelist ...
6 years, 1 month ago (2014-11-20 21:13:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744763002/1
6 years, 1 month ago (2014-11-20 21:14:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25628)
6 years, 1 month ago (2014-11-20 21:20:42 UTC) #8
Eran Messeri
Adding agl for owners approval.
6 years, 1 month ago (2014-11-20 22:08:22 UTC) #10
agl
lgtm
6 years, 1 month ago (2014-11-20 22:12:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744763002/1
6 years, 1 month ago (2014-11-20 22:24:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 22:38:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 22:38:43 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:39:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cd7715f47d0066d12c04fd83424dd427b12098e
Cr-Commit-Position: refs/heads/master@{#305092}

Powered by Google App Engine
This is Rietveld 408576698